Add in ByCode support of all type mappings on Id #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //void Type<TPersistentType>(object parameters) where TPersistentType : IIdentifierType; | ||
| //void Type(System.System.Type persistentType, object parameters); | ||
| //void Column(Action<IColumnMapper> columnMapper); | ||
| //void Columns(params Action<IColumnMapper>[] columnMapper); |
There was a problem hiding this comment.
The column methods are not lacking, they are here through inherited IColumnsMapper.
bahusoid
reviewed
Sep 14, 2018
| .Type<TPersistentType>(parameters); | ||
| } | ||
|
|
||
| public static void Type(this IIdMapper idMapper, System.Type persistentType, object parameters) |
There was a problem hiding this comment.
Isn't it the only method that needs to be added to interface? I think it's better to keep other methods as extensions and inline them.
hazzik
reviewed
Sep 16, 2018
| @@ -66,6 +67,38 @@ public void Type(IIdentifierType persistentType) | |||
| } | |||
| } | |||
|
|
|||
| public void Type(System.Type persistentType, object parameters) | |||
There was a problem hiding this comment.
In a(!) future I would like to have a method which accepts IDictionary<string, object> for parameters.
hazzik
approved these changes
Sep 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapping by code does not currently allow to set a parameterized type on ids.
This is an undue limitation, which may cause issues to users of custom types, and may also hinder usage of #1844 with mapping by code.
Having checked the xsd, this was the only case lacking full type specification possibilities in by-code. The
typeelement is used onelement,property,key-propertyandid. By code was already allowing to define parameters on the three former.